Problem/Motivation
When testing an updated version of the gitlab-runner on selected issues, some jobs would fail due to composer being run as root (https://getcomposer.org/root).
The current runners don't seem to have a problem with that, but rather than leaving this option unchecked and dependant on the runner, we should make clear via an environment variable.
Whether we change this behaviour in the future or not (ie: run commands as root or not) is out of the scope of this issue for now, but adding this fix will ensure that everything works as expected in the current and the new gitlab-runner.
Steps to reproduce
This is from core, using the new runner, but both core and contrib should have this variable set: https://git.drupalcode.org/issue/drupal-3022876/-/jobs/1305555
Proposed resolution
For now, setting COMPOSER_ALLOW_SUPERUSER=1 should be enough.
Remaining tasks
MR
Issue fork drupal-3440421
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3440421-gitlab-d.o-infra
changes, plain diff MR !7468
Comments
Comment #2
fjgarlin commentedComment #4
fjgarlin commentedReady to review first by @drumm / @nnewton / @maxwhitehead.
Comment #5
drummWe currently set
COMPOSER_ALLOW_SUPERUSER=1for all of GitLab CI since it is a requirement for the new cluster. It would be great to remove that, so it is in control of each project, in case tests are no longer running as root.Comment #10
alexpottI pushed this back all the way to 10.1.x just in case we have a security release and we need to run tests.