Problem/Motivation

In #540008: Add a container parameter that can remove the special behavior of UID#1 an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.

The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:

  1. Know these tests are correctly assigning the necessary permissions to run
  2. Can turn off the super user access policy in D11, knowing it won't break core
  3. Can remove the super user access policy in D12, providing an admin account recovery tool to replace it

Steps to reproduce

Go into any of the tests flagged with:

  /**
   * {@inheritdoc}
   *
   * @todo Remove and fix test to not rely on super user.
   * @see https://www.drupal.org/project/drupal/issues/3437620
   */

And:

  1. Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
  2. Run the test to see which test methods are failing

Proposed resolution

Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.

Remaining tasks

  • core/modules/config/tests/src/
    • Functional/ConfigExportImportUITest.php
    • Functional/LanguageNegotiationFormOverrideTest.php

Issue fork drupal-3439831

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vensires created an issue. See original summary.

vensires’s picture

Title: Fix all tests that rely on UID1's super user behavior - Config » Fix Config tests that rely on UID1's super user behavior

pradhumanjain2311 made their first commit to this issue’s fork.

thebumik made their first commit to this issue’s fork.

thebumik’s picture

Status: Active » Needs review

Added necessary changes to fix that test.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Tests are still green and permissions seem correct.

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed fb96c6ed34 to 11.x and 72da8154d4 to 10.3.x. Thanks!

  • alexpott committed 72da8154 on 10.3.x
    Issue #3439831 by thebumik, pradhumanjain2311, vensires: Fix Config...

  • alexpott committed fb96c6ed on 11.x
    Issue #3439831 by thebumik, pradhumanjain2311, vensires: Fix Config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.