The following errors are reported by PHP codesniffer:

FILE: /Users/sagarramgade/Sites/drupal-contributions/web/modules/contrib/trailless_menu/tests/modules/trailless_menu_render_count_test/trailless_menu_render_count_test.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 2
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sagarramgade/Sites/drupal-contributions/web/modules/contrib/trailless_menu/tests/src/Functional/TraillessMenuTest.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------------------------------------
  10 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
  49 | ERROR   | [x] Missing function doc comment
  61 | WARNING | [x] A comma should follow the last multiline array item. Found: 'trailless_menu main navigation'
 132 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 160 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 162 | ERROR   | [x] Visibility must be declared on method "testCacheInvalidationOnFormSave"
 185 | WARNING | [x] A comma should follow the last multiline array item. Found: 'trailless_menu footer navigation'
 222 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 233 | ERROR   | [x] Expected 1 blank line after function; 0 found
 234 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sagarramgade/Sites/drupal-contributions/web/modules/contrib/trailless_menu/src/Form/SettingsForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 29 | ERROR | [x] Do not append variable name "$cacheTagsInvalidator" to the type declaration in a member variable comment
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

Issue fork trailless_menu-3439532

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sagar Ramgade created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !6

sarwan_verma’s picture

sarwan_verma commented
Assigned: sagar ramgade » Unassigned
Status: Active » Needs review

Hi @Sagar Ramgade
i have created MR please review it.

sagar ramgade’s picture

sagar ramgade commented

Thanks @sarwan_verma, overall it looks good. I've pushed some minor text changes.

sarwan_verma’s picture

sarwan_verma commented

Hi @Sagar Ramgade,
please change the status and Fixed .

mitthukumawat’s picture

mitthukumawat commented
Status: Needs review » Reviewed & tested by the community

I run the phpcs coding standard with above changes and it looks fine now. Moving to RTBC.

sagar ramgade’s picture

sagar ramgade commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.