Problem/Motivation

Slider item render issue when no value added in slider item in theme settings it print empty slider component.

Steps to reproduce

1 Install the theme and set as default.
2 Go to the theme settings.
3 Update select number of slider display count into 3 save config.
4 Go to the home page
5 Go to 3 slide in slider component.
you will find the empty slider issue.
slider_issue

Proposed resolution

Slide should not visible in FE when value not added

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
slider_issue.PNG33.58 KBgautam_105@

Issue fork pets_clinic-3439351

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gautam_105@ created an issue. See original summary.

yogesh.k’s picture

yogesh.k commented
Assigned: Unassigned » yogesh.k

yogesh.k opened merge request !3

yogesh.k’s picture

yogesh.k commented
Assigned: yogesh.k » Unassigned
Status: Active » Needs review
Issue tags: +slider

@Gautam_105@ , i have fixed this issue and created MR for the same please review and test my MR.

gautam_105@’s picture

gautam_105@ commented
Status: Needs review » Reviewed & tested by the community

@yogesh.k i have tested MR and it's working fine for me. So moving in RTBC+ , @ravi kant Please close this issue.

ravi kant made their first commit to this issue’s fork.

ravi kant’s picture

ravi kant commented
Status: Reviewed & tested by the community » Needs work

Thank you @yogesh.k @Gautam_105@

I just made one change about alt tag on image. I am adding title as alt text.
@yogesh.k - can we add alt attribute mandatory during upload image.

yogesh.k’s picture

yogesh.k commented
Assigned: Unassigned » yogesh.k
yogesh.k’s picture

yogesh.k commented
Assigned: yogesh.k » Unassigned
Status: Needs work » Needs review

@ravi-kant for the alt tag of the slider we are creating title field required, please review.

ravi kant’s picture

ravi kant commented
Status: Needs review » Reviewed & tested by the community

Thank you @yogesh.k
Changes are updating successfully.

ravi kant’s picture

ravi kant commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.