Problem/Motivation

Remove usage of "blacklist" and "whitelist" in the editor module.

Steps to reproduce

Proposed resolution

  1. Fix all references:
    • core/modules/editor/tests/src/Unit/EditorXssFilter/StandardTest.php - Comments and data provider name
    • core/modules/editor/src/EditorXssFilter/Standard.php - Lots of comments, and only a local variable.

Remaining tasks

Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3439270

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !7359

quietone’s picture

quietone commented
Title: Replace use of whitelist/blacklist in the editor alias module » Replace use of whitelist/blacklist in the editor module
quietone’s picture

quietone commented
Status: Active » Needs work
quietone’s picture

quietone commented
Status: Needs work » Needs review
quietone’s picture

quietone commented
Status: Needs review » Needs work

This will need some deprecations for method name changes.

magaki’s picture

magaki
Primary language Japanese
commented
Assigned: Unassigned » magaki
magaki’s picture

magaki
Primary language Japanese
commented
Assigned: magaki » Unassigned
Status: Needs work » Needs review

I added deprecation to providerTestBlackListMode and created a change record.
https://www.drupal.org/node/3461718

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Novice, +Needs Review Queue Initiative

Left some comments on the MR.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Updated the MR with deprecation message as per the suggestion ~~ hence moving into review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed.

  • catch committed ef97485d on 11.x 
    Issue #3439270 by quietone, magaki, ankitv18, smustgrave: Replace use of...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Methods in individual tests (and the entire tests themselves) are considered internal and we don't normally add bc for those even on a best effort basis. Committed/pushed to 11.x but without that hunk from the MR.

catch closed merge request !7359

quietone’s picture

quietone commented
Parent issue: » #2993575: [meta] Remove usage of "blacklist", "whitelist", use better terms instead

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jacobupal’s picture

jacobupal commented
Issue tags: -Novice