Problem/Motivation

I found 3 bugs related to admin toolbar header, describing them at once because the fixes are related between each other.

1. Shortcuts are not visible in mobile navigation

test

I have added margin-top for shortcuts and here it is (obviously it's not the right thing to solve this issue like this, i did it just to demonstrate the issue)

test

2. With option "Hide logo" on this page admin/config/user-interface/navigation/settings

test

we have horizontally left aligned cross btn on mobile navigation (but should be right aligned):

test

3. Same situation with "Hide logo" option, but another bug on desktop device:

test

we have unexpected padding -> on desktop we shouldn't have it coz no logo

CommentFileSizeAuthor
Снимок экрана 2024-04-05 в 15.06.11.png604.74 KBkostyashupenko
Снимок экрана 2024-04-05 в 15.05.28.png36.91 KBkostyashupenko
Снимок экрана 2024-04-05 в 15.06.16.png103.66 KBkostyashupenko
Снимок экрана 2024-04-05 в 15.17.25.png21.7 KBkostyashupenko
Снимок экрана 2024-04-05 в 15.05.52.png549.38 KBkostyashupenko

Issue fork navigation-3438850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kostyashupenko created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Issue summary: View changes

kostyashupenko opened merge request !233

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: kostyashupenko » Unassigned
Status: Active » Needs review

Please test all 3 issues and review MR

ckrina made their first commit to this issue’s fork.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed

I made a few spacing adjustments to match the designs, but thanks @kostyashupenko for spotting these bugs!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.