Problem/Motivation
Currently if a user updates the hostname in the configuration the new URL is added to the script that is loaded in the head but the noscript found in the body does not have a variable set to update the hostname dynamically. For consistency this hostname also needs to reflect the hostname set in the config.
Steps to reproduce
If you update the hostname in the configuration and inspect the site you will see that the URL is updated in the head script but not in the noscript section found in the body.
Proposed resolution
I have created a patch that adds an additional host name variable that will be available in the twig file so that the noscript URL can also be updated. I will add the patch in the first comment below.
Remaining tasks
Only review and testing should be needed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | add_host_name_variable_to_noscript_iframe-3438213-2.patch | 2.02 KB | roaldnel |
Comments
Comment #2
roaldnel commentedThe patch is attached.
Comment #3
yustintr commentedI have updated the host URL in the configuration, which successfully changed the host in both the head and the noscript sections of the body.
Comment #5
roaldnel commentedThank you for reviewing the change yustinTR. I have committed the changes and released version 1.0.17 with the updated code.