Problem/Motivation

here is git blame https://git.drupalcode.org/project/navigation/-/blame/1.x/css/components...

breadcrumbs were integrated and then modified several times for the past months. Need to get rid of all css, (and logic in php + twig if exist) from navigation module

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 Снимок экрана 2024-04-04 в 13.04.11.png180.05 KBkostyashupenko

Issue fork navigation-3437854

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kostyashupenko created an issue. See original summary.

kostyashupenko opened merge request !228

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new Снимок экрана 2024-04-04 в 13.04.11.png180.05 KB

I also removed useful from my pov navigation_preprocess_breadcrumb hook which was added to add an extra link "Back to site" in breadcrumbs:

test

Tell me if we have to keep it or not. But from my pov it should be handled not in the scope of Navigation module

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Fixed

Thanks for this! Merged to 1.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.