Problem/Motivation

mglaman/phpstan-drupal released version 1.2.10 which allows services.yml to contain custom tags (https://github.com/mglaman/phpstan-drupal/pull/743).

Let's update to this version to allow MRs like in #3432595: Use a tagged service iterator for uninstall validators instead of individual lazy proxies to pass and be thoroughly tested.

Steps to reproduce

Proposed resolution

- $ composer update phpstan/phpstan mglaman/phpstan-drupal -W
- $ vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline core/.phpstan-baseline.php
- Bump version of mglaman/phpstan-drupal in composer.* to latest, since it fixes a PHPStan crash over in #3432595: Use a tagged service iterator for uninstall validators instead of individual lazy proxies.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3437778

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !7297

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Note: Creating a new PHPStan-baseline exposed some formatting differences between the generated and committed-in-HEAD one.
Let's use this issue to reconcile these.

As a side note: If people are manually editing the baseline, let's make the GitLab job fail on these differences, so we don't need this kind of reconciliation.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Let's bump the minimum version of mglaman/phpstan-drupal here, because it fixes a PHPStan crash over in #3432595: Use a tagged service iterator for uninstall validators instead of individual lazy proxies

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
Status: Needs work » Needs review

Ah crap, of course, forgot that in my "rage" about the baseline formatting.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 8fe4fb0 and pushed to 11.x. Thanks!
Committed 1e955e9 and pushed to 10.3.x. Thanks!

I fixed the composer.lock conflicts and backported to 10.3.x

  • alexpott committed 1e955e9e on 10.3.x 
    Issue #3437778 by Spokje, longwave: Bump phpstan/phpstan and mglaman/...

  • alexpott committed 8fe4fb06 on 11.x 
    Issue #3437778 by Spokje, longwave: Bump phpstan/phpstan and mglaman/...

Spokje closed merge request !7297

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.