Closed (fixed)
Project:
Sobki Admin Theme
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2024 at 11:21 UTC
Updated:
1 Jan 2025 at 09:34 UTC
Jump to comment: Most recent
This issue is open to allow testing of Gitlab Templates pipelines and assist with fixes and enhancements.
The merge request MR1 will remain in 'draft' status to indicate that it is not for merging.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
jonathan1055 commentedI have tested your project using the MR I have created on #3436819: Composer-lint fails if there are no php files in the project. This is done using
The composer-lint job now passes, and gives a message that 0 PHP files were found in the project.
https://git.drupalcode.org/issue/sobki_theme_admin-3436970/-/jobs/1201439
Comment #5
grimreaperThanks a lot @jonathan1055!
Waiting for the fix inside gitlab_templates directly.
Comment #6
jonathan1055 commented#3436819: Composer-lint fails if there are no php files in the project has just been merged and you can see the commit listed in this link: compare/default-ref...main?from_project_id=96292. This shows all commits that are in 'main' but not yet reached 'default-ref'.
You can also see all the commits and where the tags are. You can see at the moment there are three commits which are above the set of
'4 tags', meaning that these are only in 'main'Would you be OK if you left this MR open, marked as draft. Then we can use it to test other gitlab_templates MRs. There are so many varieties of contrib modules, that it has been very useful to have MRs on some projects, where the maintainer takes an active interest in improving and fixing GitLab Tempates. Thanks.
Comment #7
grimreaperHi @jonathan1055,
Thanks a lot to have pushed this forward!
No problem to keep the MR opened, if this may help. What about the issue? In which status should it remain?
Next issue I want to create is about PHPStan task triggered while there is currently no PHP files in this theme.
Comment #8
jonathan1055 commentedI have updated the issue summary and set the issue status to 'active'. I think that accuratelty reflects what is going on here.
Yes, open a new issue for PHPStan. I can work on it, and then will test it here. Thanks for your help.
Comment #9
grimreaperThanks!
PHPStan issue created #3437578: PHPStan job fails while there is no PHP files to scan.
Comment #10
jonathan1055 commentedI have just used this MR1 to test the fix on #3437578: PHPStan job fails while there is no PHP files to scan
Here's the pipeline:
https://git.drupalcode.org/issue/sobki_theme_admin-3436970/-/pipelines/1...
The phpstan job has not been added, which shows the fix works.
Comment #12
grimreaperAs discussed with @jonathan1055, the issue and MR can be closed and re-open if needed.