Problem/Motivation

The call method dispatches an event (http_client.call_pre_execute) to let other modules interacting with client and command variables. The problem is that when the client executes the command, we are not using the updated version of either client and command variables.

Steps to reproduce

Subscribe to the http_client.call_pre_execute event and modify the client or the command. Nothing will happen.

Proposed resolution

Use the $event->client and $event->command variables instead of $client and $command.

API changes

After this change the "onDataIntegrityCheck" method of the "HttpClientManagerSubscriber" will start working properly again. Please double check nothing changed on your service requests.

CommentFileSizeAuthor
#6 3436968-5.patch545 bytesaronne
#2 3436968-2.patch522 bytesaronne

Comments

aronne created an issue. See original summary.

aronne’s picture

StatusFileSize
new522 bytes

Here is the patch.

aronne’s picture

Status: Active » Needs review
aronne’s picture

Status: Needs review » Fixed

  • 0aca241a committed on 9.3.x
    Issue #3436968 by aronne: HttpClient call doesn't use the updated...
aronne’s picture

StatusFileSize
new545 bytes

This one is for 3.x

  • df6d8dbb committed on 3.x
    Issue #3436968 by aronne: HttpClient call doesn't use the updated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.