In #2575105: Use cache collector for state we added a new optional setting to allow the state key-value store to be stored as a single cache entry to improve performance. This was optional because some sites store data that shouldn't be there in state.
In Drupal 11, we can remove this setting and enable the state cache permanently.
Deprecate $settings['state_cache'].
Remove any references to the setting and enable the state cache permanently.
Remove other deprecations introduced in #2575105: Use cache collector for state
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !7273
Comments
Comment #3
longwaveComment #4
smustgrave commentedSince this will require sites to update their settings.php should a CR be included.
Comment #5
longwaveUnsure if we can use the existing change record given we only just introduced this, or if we should have a separate one: https://www.drupal.org/node/3177901
That CR also says Drupal 12+ but this issue says 11...
Comment #6
smustgrave commentedSo that CR/ticket was only committed for 10.3, which isn't released yet. So imagine updating the CR to more mention this setting is only for D10.3+ and automatic in D11. Thoughts?
Comment #7
longwaveI think let's update the existing change record to mention Drupal 11 instead of 12 and say what to do when Drupal 11 is released.
Comment #8
quietone commentedI agree that the existing change record should be updated as needed. However, there should be 2 changes records; one for the change that happens in 10.3.0 and one for the change that happens only in 11. They are distinct events. So, there should have a CR for each.
Comment #9
smustgrave commentedUpdated existing CR #3177901: State service now uses a cache collector for performance
Created new CR #3443018: Settings 'state_cache' is removed and permanently turned on
But should $this->cacheLoaded = TRUE; be added tocore/lib/Drupal/Core/State/State.php
Comment #10
smustgrave commentedUpdated the CR and tests were green before. I just rebased.
Comment #12
catchCommitted/pushed to 11.x, thanks!