Problem/Motivation

Text.settings contains a single key that's only used in one spot.

Steps to reproduce

NA

Proposed resolution

Drop the text.settings file since it's used in one spot

Remaining tasks

Review

User interface changes

NA

API changes

text.settings is removed

Data model changes

NA

Original post

For example: \Drupal\text\Plugin\Field\FieldFormatter\TextTrimmedFormatter::defaultSettings() we could reuse the value here.

Release notes snippet

Issue fork drupal-3436677

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar.podey created an issue. See original summary.

omkar.podey’s picture

omkar.podey commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Either Remove default_summary_length config in text.settings or reuse it. » Either remove default_summary_length config in text.settings or use it in TextTrimmedFormatter
Issue tags: +clean-up

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !14446

smustgrave closed merge request !14446

smustgrave opened merge request !14447

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Ended up just dropping the entire settings file, it was only used in 1 spot.

dcam’s picture

dcam commented
Status: Needs review » Needs work
Issue tags: +Needs update path tests, +Needs issue summary update

I left an MR comment.

...oh, and do we need an update path test?

The issue title and summary need some work if the resolution has been settled upon.

smustgrave’s picture

smustgrave commented
Title: Either remove default_summary_length config in text.settings or use it in TextTrimmedFormatter » Remove text.settings config since it's only used in 1 place
Issue summary: View changes

This one may be simple enough it may not need upgrade test coverage since it's just dropping a file.

As far as the post_update vs install I'm never good about which is best. I've kinda leaned that basic configuration goes into install. Let me see if I can find out.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.