Problem/Motivation

Twitter/X icon needs updating to use X instead of the old bird icon.

Proposed resolution

Edit page.html.twig to update icon source.

Before:
<img class="usa-social-link__icon" src="{{ uswds_images }}usa-icons/twitter.svg" alt="Twitter">

After:
<img class="usa-social-link__icon" src="{{ uswds_images }}usa-icons/x.svg" alt="Twitter">

CommentFileSizeAuthor
#6 Screenshot from 2024-03-28 00-41-04.png36.83 KBsourojeetpaul

Issue fork uswds_base-3436528

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fkildoo created an issue. See original summary.

sourojeetpaul made their first commit to this issue’s fork.

sourojeetpaul’s picture

sourojeetpaul commented
Assigned: Unassigned » sourojeetpaul

Working on it!

sourojeetpaul opened merge request !66

sourojeetpaul’s picture

sourojeetpaul commented
StatusFileSize
new Screenshot from 2024-03-28 00-41-04.png36.83 KB
sourojeetpaul’s picture

sourojeetpaul commented
Assigned: sourojeetpaul » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot from 2024-03-28 00-41-04.png36.83 KB

Hi, @fkildoo.
I've resolved the twitter logo related issue by updating it to the latest one and raised an MR.
Please have a look : https://git.drupalcode.org/project/uswds_base/-/merge_requests/66

Had to update the referenced CDN to the latest version, which has the new X svg on it. Also checked that other logos are also appearing properly after the CDN update.
Social Icons

fkildoo’s picture

fkildoo commented

The update looks good except I wouldn't update the CDN version until the version of this theme matches. The X social media icon was introduced in USWDS 3.7.0 so no need to update the CDN for this change.

From the release notes:

Added the X social media icon. We added the X social media icon, but also preserved the legacy Twitter icon to allow teams to make the decision on when to update their social media information. (#5589)

https://github.com/uswds/uswds/pull/5589

mferanda’s picture

mferanda commented
Status: Needs review » Active

Looks like X was available with 3.7.0...

This change should just be to the twitter image to x.

I'll update all the CDNs to 3.7.1 separately. We can then just push this out as a 3.7.1 update instead of waiting on 3.8.0.

mferanda’s picture

mferanda commented

Modified this to only a change from twitter to x img.

mferanda’s picture

mferanda commented
Status: Active » Fixed
mferanda’s picture

mferanda commented
Status: Fixed » Closed (fixed)