Closed (fixed)
Project:
UI Suite USWDS
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2024 at 10:52 UTC
Updated:
16 Apr 2024 at 12:34 UTC
Jump to comment: Most recent
Gitlab templates has an enhancement to automatically add the Lorum Ipsum dictionary to cSpell, to save maintainers the trouble of having to ignore all of this. See #3436206: Add lorem-ipsum spelling dictionary
The work is ready to be tested, and can be done by adding the following into .gitlab-ci.yml
# MR 165 Add lorem-ipsum dictionary
- project: issue/gitlab_templates-3436206
ref: 3436206-lorem-ipsum-dictionary
variables:
_CURL_TEMPLATES_REPO: issue/gitlab_templates-3436206
_CURL_TEMPLATES_REF: 3436206-lorem-ipsum-dictionary
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jonathan1055 commentedFirst commit removes the
cspell:disable-next-linefrom seven files that have the "Lorem ipsum" lines. The cspell job fails as expected.https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130459
Comment #4
jonathan1055 commentedNow a pipeline using gitlab_templates MR165
https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130466
Interestingly this does not pass as expected. All of the words are OK except one
The suggestion for replacement is "consectetur" which is obviously the word in the lorum-ipsum dictionary. This word is already used and spelled correctly in four of the files, but wrong in the other three.
Comment #5
jonathan1055 commentedI fixed the spelling in the three files, I guess it was a copy/paste from one original that was wrong somehow. The job passes green.
https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130484
When the gitlab_templates MR has been merged and then rolled out to all contrib on the 'default-ref' branch then this MR can be committed. The temporary change to .gitlab-ci.yml here will need to be removed before merging.
Comment #7
smustgrave commentedThat was a fast fix!
Comment #8
jonathan1055 commentedJust be aware that with the above commit you are now using a gitlab_templates version which is currently slight ahead of the 'default-ref' but is also static. In due course you will want to revert just the .gilab-ci.yml change to put back
which will use the recommended 'default-ref', and delete the two $_CURL variables. There is no hurry, as the MR still exists and will be usable, but you will not be getting any of the newer work when 'default-ref' gets updated.
When #3436206: Add lorem-ipsum spelling dictionary is merged you will see the commit listed in this link: compare/default-ref...main?from_project_id=96292
This shows all commits that are in 'main' but not yet reached 'default-ref'. If the commit is showing here then you need to wait.
You can also see all the commits and where the tags are. This currently shows three commits which are above the set of tags, meaning that these are only in 'main' and have not yet reached 'default-ref'
Comment #10
jonathan1055 commentedAdded #3441285: Set gitlab templates project and ref back to default to return to the default template