In contemplate, there is
$node->content['discussthis_comments']['#value']

which I assumed would be empty if I had not created a forum topic at all. But it has the following value automatically so it is never empty.

Can we change this so that it is empty if there are no forums?

CommentFileSizeAuthor
#1 342841_empty_content_value.patch918 bytesksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Version: 5.x-1.0 » 5.x-1.x-dev
Assigned: Unassigned » ksenzee
Status: Active » Needs review
StatusFileSize
new 342841_empty_content_value.patch918 bytes

Give this patch a try. It's against the -dev version but it should still apply to 5.x-1.0.

socialnicheguru’s picture

socialnicheguru commented

doesn't seem to workl

Here is what an empty book produces:

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Assigned: ksenzee » spiderman
Status: Needs review » Postponed (maintainer needs more info)

@activelyOUT: I can't seem to reproduce your bug- can you provide more details on your setup? specifically, can you tell me what modules you are using (related to discussthis), what content types/fields you have configured, and what your discussthis settings look like? Also, if you can include some more details on what the buggy output looks like, that'd be great (looks like you tried to do this, but maybe the cut/paste didn't work? ;)

If it helps, I've tried this on a stock Drupal 5 install, with only discussthis and forum modules enabled, using a basic user role with perms to post in forums and initiate discussthis topics. Viewing nodes with this user, I can see the 'discussthis-comment' item list on nodes that have forum topics created for them, and not on ones that don't. Am I missing something?

Sorry I've been slow to get to this, but I'm eager to resolve any outstanding issues so I can port this module to D6, so if this is really a bug, I'd love to squish it asap :)

Thanks!

dom.’s picture

dom. commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Module maintainer has changed. I'm closing this issue after years of inactivity, please open a new issue if needed.