Problem/Motivation

We're trailing behind with phpstan/phpstan and mglaman/phpstan-drupal.

I'm sure this will be fixed at some point with the massive update issues when 10.3.0 will be released, but why miss out on all the new goodness that must be in there.

Steps to reproduce

Proposed resolution

- $ composer update phpstan/phpstan mglaman/phpstan-drupal -W
- $ vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline core/.phpstan-baseline.php
- Bump version of phpstan/phpstan in composer.* to latest, since the newly created baseline won't pass on any lower version.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3428052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Spokje opened merge request !7054

spokje’s picture

spokje
Primary language Dutch
commented

Failure due to (already spotted) broken HEAD:#3428032: ManageGitIgnoreTest failing in HEAD

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

HEAD unbroken, rebased, all is well...

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Bump didn't seem to break anything, why not!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

We need to answer @mondrake's question.

spokje’s picture

spokje
Primary language Dutch
commented

Dropped some lines as a response, let's see what @mondrake thinks about this.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed b01f7e3 and pushed to 11.x. Thanks!
Committed 28e8016 and pushed to 10.3.x. Thanks!

  • alexpott committed 28e80166 on 10.3.x 
    Issue #3428052 by Spokje, mondrake: Bump phpstan/phpstan and mglaman/...

  • alexpott committed b01f7e30 on 11.x 
    Issue #3428052 by Spokje, mondrake: Bump phpstan/phpstan and mglaman/...

Spokje closed merge request !7054

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.