Problem/Motivation

The HTML specification does not allow a div element inside a button element, as is done in clipboardjs-textfield.html.twig.

Proposed resolution

Replace this element with a span element.

Ultimately, it would be a good idea to remove that wrapper element altogether, but that could cause compatibility issues with styles.

Remaining tasks

Agree on change. Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork clipboardjs-3427725

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !10

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Version: 2.0.x-dev » 2.1.x-dev
Assigned: Unassigned » tim-diels

Thanks for the suggestion. I'll review this.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: tim-diels » Unassigned
Status: Needs review » Reviewed & tested by the community

Does not break anything for me.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.