Problem/Motivation

in css reset ticket we got failback `--admin-toolbar-rem` but seems css wasn't generated well there. So now in 1.x `yarn build` command transform variables to --admin-toolbar-rem: max(1rem, 1rem); what is incorrect in terms of that failback.

Proposed resolution

set --admin-toolbar-rem: max(1rem, 16PX);
to avoid its transformation

https://www.npmjs.com/package/postcss-pxtorem#a-message-about-ignoring-p...

CommentFileSizeAuthor
#6 3427520-1.patch945 bytesrishabjasrotia

Issue fork navigation-3427520

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky’s picture

finnsky commented
Status: Active » Needs review

finnsky opened merge request !196

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Commenting here also what I've mentioned in Slack for the record: I’m actually wondering if we should really be using postcss-px-to-rem and just write the code with the unit it needs and get rid or auto-conversions. IMHO our code is small enough to control that.

finnsky’s picture

finnsky commented

@ckrina i think we need to merge this small fix,
because `yarn build` now always generate that 1rem-1rem :)

And probably reopen discussion ticket

rishabjasrotia’s picture

rishabjasrotia commented
StatusFileSize
new 3427520-1.patch945 bytes

Patch tested working fine.

finnsky’s picture

finnsky commented

@rishabjasrotia
Why extra patch needed here?

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed
Related issues: +#3428036: Remove postcss-px-to-rem from Navigation

Fixed, thanks @finnsky! I've also added a comment next to it so it's obvious why it's there and opened #3428036: Remove postcss-px-to-rem from Navigation.

@rishabjasrotia thank you for your interest in working on this issue.
This issue works with a merge request (MR), so posting additional patches (especially with the same code) is not helpful. In general, patches should be avoided from now on.
In the future, you can get credit for issues by reading the issue to understand its purpose, and taking into account all the discussion on the issue. More information on the issue credit guidelines. Thanks!

rishabjasrotia’s picture

rishabjasrotia commented

Hello @finnsky it is the same code patch added until issue was not merged to be used.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.