Problem/Motivation

Inspired by #2914110: Shortcut hook_toolbar implementation makes all pages uncacheable & #3426626: ShortcutsNavigationBlock is not being cached properly, we found that the way UserNavigationBlock is implemented, pages are not being cached properly. This causes the Dynamic page cache to stop working, since the cardinality is too high.

Steps to reproduce

Proposed resolution

Implement a Lazy Builder to use a cached placeholder for UserNavigationBlock

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork navigation-3427114

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Related issues: +#2914110: Shortcut hook_toolbar implementation makes all pages uncacheable, +#3426626: ShortcutsNavigationBlock is not being cached properly

plopesc opened merge request !189

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Priority: Major » Critical
Status: Active » Needs review

MR created

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: plopesc » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks great! I just added in some coding standards fixes to move us along. phpcs is happy now. RTBC.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

  • ckrina committed 47aee873 on 1.x authored by plopesc 
    Issue #3427114: UserNavigationBlock implementation makes all pages...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.