Problem/Motivation

Provide tests for UserNavigationBlock plugin.

Issue fork navigation-3426576

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei

I'm going to work on this, this afternoon and see how far I get.

m4olivei opened merge request !209

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Active » Needs review
Issue tags: +backend

This is ready for review!

Unlike for SystemMenuNavigationBlockTest, I ended up writing a functional test as well b/c the lazy builder in \Drupal\navigation\Plugin\NavigationBlock\UserNavigationBlock means most of the interesting bits to test need a full rendering.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Needs work

Code looks great!

Just a added a minor code suggestion.

I would encourage to add more specific assertions to ensure cache is behaving as expected, see comment in MR.

Thank you!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Related issues: +#3436937: Navigation Bar implementation makes all pages uncacheable

Took the freedom to create #3436937: Navigation Bar implementation makes all pages uncacheable to handle the caching issues and their possible ramifications.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs work » Needs review

With the fixes from #3436937: Navigation Bar implementation makes all pages uncacheable, we should be all set here.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.