Problem/Motivation

Add test coverage for NavigationBlockForm inspired in BlockForm class

Issue fork navigation-3426529

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

m4olivei created an issue. See original summary.

m4olivei opened merge request !185

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Active » Needs review
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Great job @m4olivei!

Just a minor comment regarding an unused class property.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Needs work
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs work » Needs review

Thanks for pointing that out @plopesc. All fixed!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

All good from my side!

Marking as RTBC.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.