Closed (fixed)
Project:
Group
Version:
3.3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
7 Mar 2024 at 14:51 UTC
Updated:
26 Mar 2024 at 13:09 UTC
Jump to comment: Most recent
Follow-up from #3395776: Make POST requests render cacheable.
Essentially it turned out that adding these checks didn't do anything to begin with On POST requests: We would never get a cache hit, nor set the cache. Now we can get a cache hit, which doesn't run said code or still do not set anything on a cache miss. So worst case scenario the code runs but has no effect. The upside is that if we remove the check and we somehow do end up supporting cache sets on POST (fat chance in hell) that our code won't be insecure. If we leave the check, it will be.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
kristiaanvandeneyndeNeeds a CR for the deprecation and the link added to the MR.
Comment #5
kristiaanvandeneynde