Problem/Motivation

Add tests for SystemMenuNavigationBlock based on the ones defined in SystemMenuBlockTest.

Issue fork navigation-3426374

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !184

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

MR created

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Needs work

Thanks @plopesc! See comments, all small tweaks needed.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Thank you for your feedback @m4olivei!

Comments addressed. I hope it's ready now.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Needs work

Changes look great! Just noticing that phpcs is complaining about some of the new code here. Do you mind making those adjustments?

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Thank you for the heads up @m4olivei!

Went ahead and fixed not only the phpcs issues related to this tests to leave the ground clean.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

Sweet, sweet, green checkmark ✅.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

  • ckrina committed b2de0262 on 1.x authored by plopesc 
    Issue #3426374: Tests for SystemMenuNavigationBlock

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.