Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3425956.patch16.96 KBrishabjasrotia
#2 3425956-2.patch4.99 KBchaitanyadessai

Issue fork facets_pretty_paths-3425956

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chaitanyadessai created an issue. See original summary.

chaitanyadessai’s picture

chaitanyadessai commented
Status: Active » Needs review
StatusFileSize
new 3425956-2.patch4.99 KB

Please review.

rishabjasrotia made their first commit to this issue’s fork.

rishabjasrotia opened merge request !11

Status: Needs review » Needs work

The last submitted patch, 2: 3425956-2.patch, failed testing. View results

rishabjasrotia’s picture

rishabjasrotia commented
Status: Needs work » Needs review

Hello @chaitanyadessai,
Thank you for the patch.

We should use the Drupal RouteObjectInterface as per Drupal 10 instead of \Symfony\Cmf\Component\Routing\RouteObjectInterface.
I have updated the code.

rishabjasrotia’s picture

rishabjasrotia commented
StatusFileSize
new 3425956.patch16.96 KB

Jasjeet Kaur Brar made their first commit to this issue’s fork.

jasjeet kaur brar’s picture

jasjeet kaur brar commented

Green Tick for phpcs across board

rishabjasrotia’s picture

rishabjasrotia commented

Thank you @jasjeet-kaur-brar