Problem/Motivation

We discovered that we made an mistake in #3401867: Validate config that gets imported from modules or the recipe's config directory and #3401723: Config modified by action plugins should be validated after it is saved - we validate all config the recipe touches, but not all config is actually validatable. Core ships a fair amount of config that is invalid out of the box (for example, any simple config without a langcode property would run afoul of our validation).

This has the sad effect of making the recipe system unusable in many situations. Since recipes are being used in the wild, this is breaking actual users and sites, so this issue is critical.

Proposed resolution

Core's solution for this is to only validate config that has the FullyValidatable constraint. We should follow core's lead, and only validate config which has that constraint.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Title: Only validate config which is is fully validatable » Only validate config which is fully validatable
phenaproxima’s picture

Status: Active » Needs review
narendrar’s picture

Overall changes in code looks good to me and can be marked as RTBC, but I have a doubt in test implemented.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

This looks great - a necessary relaxation.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 73d63f1e5a5 to 11.x and 6a5bb3071bb to 10.2.x. Thanks!

  • alexpott committed 6a5bb307 on 10.2.x
    Issue #3425540 by phenaproxima, narendraR: Only validate config which is...

  • alexpott committed 73d63f1e on 11.x
    Issue #3425540 by phenaproxima, narendraR: Only validate config which is...

  • 54c6aa37 committed on patch
    Update recipe 11.x patch 73d63f1e Issue #3425540 by phenaproxima,...

  • alexpott committed f097dba9 on 10.2.x
    Revert "Issue #3425540 by phenaproxima, narendraR: Only validate config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.