Problem/Motivation
We discovered that we made an mistake in #3401867: Validate config that gets imported from modules or the recipe's config directory and #3401723: Config modified by action plugins should be validated after it is saved - we validate all config the recipe touches, but not all config is actually validatable. Core ships a fair amount of config that is invalid out of the box (for example, any simple config without a langcode property would run afoul of our validation).
This has the sad effect of making the recipe system unusable in many situations. Since recipes are being used in the wild, this is breaking actual users and sites, so this issue is critical.
Proposed resolution
Core's solution for this is to only validate config that has the FullyValidatable constraint. We should follow core's lead, and only validate config which has that constraint.
Issue fork distributions_recipes-3425540
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3425540-only-validate-config
changes, plain diff MR !87
Comments
Comment #3
phenaproximaComment #4
phenaproximaComment #5
phenaproximaComment #6
narendrarOverall changes in code looks good to me and can be marked as RTBC, but I have a doubt in test implemented.
Comment #7
alexpottThis looks great - a necessary relaxation.
Comment #8
alexpottCommitted and pushed 73d63f1e5a5 to 11.x and 6a5bb3071bb to 10.2.x. Thanks!