Problem/Motivation

For a non-administrate role to convert a bundle type, the "Administer Convert Bundles" must also be assigned for the user to access the page. This gives more access than it is required to make a simple convert.

Steps to reproduce

If you assign only a entity_type: Convert Bundle permission, the user can see the Convert Bundle option in the edit page of the entity, but then the user has no access to the page.

Proposed resolution

Alter the permission of the form so the user can access it. Preferably in the buildForm.

Issue fork convert_bundles-3425409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Arccoss created an issue. See original summary.

prudloff made their first commit to this issue’s fork.

prudloff opened merge request !25

prudloff’s picture

prudloff commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks for the merge request, great initiative. With that said, I would prefer if we hold off merging this until it becomes a configuration option. So make the normal behavior occur unless the simplified permissions option is configured.

a new config option "Simplified permissions" is needed for this to be mergeable so that those that want permission granularity are able to keep it.

I'm fine with this being an opt-in or opt-out, either way but it must be configurable.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I'll have to test this myself and see how it works.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

merged https://git.drupalcode.org/project/convert_bundles/-/commit/9788d8167349...

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

This is committed to the 2.0.x dev branch. I'll let it simmer in there since permissions should ideally be expanded to limit the select dropdown options.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

not yet in a tagged release but it is in 2.0.x dev

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 2.0.x-dev » 3.0.x-dev

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

#3472070: Refactor module to use a dedicated service, batch, & helper trait

FYI

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.