Postponed
Project:
Drupal core
Version:
main
Component:
editor.module
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
4 Mar 2024 at 09:50 UTC
Updated:
12 Mar 2024 at 11:48 UTC
Jump to comment: Most recent
Problem/Motivation
#3231364: Add CKEditor 5 module to Drupal core introduced \Drupal\ckeditor5\Plugin\Editor\CKEditor5::validatePair() (and type: ckeditor5_valid_pair__format_and_editor) because there was no other way to validate that a text editor + text format are in sync.
But now that #3412361: Mark Editor config schema as fully validatable has landed, we can move the necessary validation constraints to type: editor.editor.* 🥳
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3425349
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersZero
Functionaltest failures now 👍Comment #4
wim leersIt's thanks to the very detailed test coverage in
\Drupal\Tests\ckeditor5\Kernel\ValidatorsTestthat a critical oversight inConfigEntityAdapterwas discovered. 🫣#1818574: Support config entities in typed data EntityAdapter introduced
\Drupal\KernelTests\Core\Entity\ConfigEntityAdapterTest::testValidate(), but it is inadequate. We need additional test coverage, and this probably should be handled in its own issue.See https://git.drupalcode.org/project/drupal/-/merge_requests/6892/diffs?co... for the relevant changes.
Comment #5
wim leersComment #6
wim leersThis blocks #3231354: [PP-2] [META] Discuss: merge the Editor config entity into the FilterFormat config entity.
Comment #7
wim leersThis also blocks the Recipes initiative at #3401925: After a recipe is successfully applied, validate *all* fully validatable config.
Comment #8
wim leersFollow-up created: #3427106: Config validation: config entities should get the same validation errors when validated as plain config vs ConfigEntityAdapter. Pushed it forward far enough that it's now clear that that will work, and that it SHOULD happen ASAP.
All of the changes that the current MR makes outside of
core/modules/ckeditor5will disappear from this MR once #3427106: Config validation: config entities should get the same validation errors when validated as plain config vs ConfigEntityAdapter lands. So ceasing all work on this MR until that lands 👍