Problem/Motivation

The way drush commands are written in Drush 12 has changed see https://www.drush.org/12.x/commands/
Drush 12 still works with the previous implementation but Drush 13 for Drupal 11 will have this BC layer removed. So we need to change the drush commands to fit the new way of declaring them.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

Issue fork config_split-3424108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Version: 2.0.x-dev » 8.x-1.x-dev

lamp5 opened merge request !42

bircher’s picture

bircher
Location 🇨🇿
commented
Status: Active » Needs work

I don't think it is that simple.

Check out https://www.drush.org/12.x/commands/

We will need to change the drush commands a bit.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented

Sure, I debug the process of services registration and I detected that it is a problem with that, I can't see any issue using drush 12 and config split right now.

bircher’s picture

bircher
Location 🇨🇿
commented
Title: Support latest versions of drush for drush.services.yml » Update drush integration for Drush 12+
Issue summary: View changes
Related issues: +#3362191: Remove Drush 8 integration

yea we can use this issue for fixing the drush integration also going forward since in Drush 13 deprecated behaviour will be removed.
Drush 11 and Drupal 9 are EOL so we can just go ahead and do this now.
See also #3362191: Remove Drush 8 integration

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

Other problem is that config-split:* Drush commands are not picked up any more with
drupal/core 10.5.1
drush/drush 12.5.3.0
drupal/config_split 2.0.2

Because config_split/composer.json

  "extra": {
    "drush": {
      "services": {
        "drush.services.yml": "^10 || ^11"
      }
    }
  }
bircher’s picture

bircher
Location 🇨🇿
commented
Title: Update drush integration for Drush 12+ » Update drush integration for Drush 13.7+
Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: Unassigned » bircher
Status: Needs work » Active

With Drush 13.7 we can use Listeners to react to the config:export so we don't need the drush hook any more and so we can refactor everything to be auto detected and be ready for Drush 14 where the current implementation won't work any more.

bircher opened merge request !58

  • bircher committed 5bf75a62 on 2.0.x 
    Issue #3424108 by bircher: Update drush integration for Drush 13.7+
bircher’s picture

bircher
Location 🇨🇿
commented
Status: Active » Needs review
bircher’s picture

bircher
Location 🇨🇿
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.