Problem/Motivation

When anonymously accessing a forbidden route while having "user" query parameter, the response will be a redirect to the originally requested URL, and therefore, the user will encounter an infinite redirect loop.

This is caused by betterlogin module and there's an existing patch that fixes the issue.

ERR_TOO_MANY_REDIRECTS

Steps to reproduce

  1. With fresh Varbase installation
  2. Anonymously navigate to /admin?user=x
  3. Observe the redirect loop

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-9.1.2, varbase_core-9.1.27

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3424034 by Redwan Jamous: Added 3422610-4.patch to Better Login to fix Redirect loop when accessing a forbidden route with 'user' query parameter
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Redwan Jamous created an issue. See original summary.

Redwan Jamous changed the visibility of the branch 3424034-add-3422610-4.patch-to to hidden.

redwan jamous’s picture

Assigned: redwan jamous » Unassigned
Issue summary: View changes
Status: Active » Needs review
rajab natshah’s picture

Issue summary: View changes

Tested
Before the patch:
Going to "/admin?user=2" for example will hit ERR_TOO_MANY_REDIRECTS

After applying the patch:
the site will redirect to "/user/login?destination=user"

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase-9.1.2, +varbase_core-9.1.27
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase_core-9.1.27

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.1.2