Problem/Motivation

Switch from DrupalCI testing to Drupal Gitlab templates.

Steps to reproduce

Proposed resolution

Remaining tasks

  • Clarify why a D10.2 composer build in Gitlab CI is working and with DrupalCI not.
  • Fix issues reported by PHPSTAN (suggestion do this in a separate issue)
  • Remove all DrupalCI automated tests, when issue is fixed

User interface changes

API changes

Data model changes

Issue fork cloudflare-3423376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

IT-Cru created an issue. See original summary.

IT-Cru opened merge request !17

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Assigned: it-cru » Unassigned
Issue summary: View changes
Status: Active » Needs review
rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Needs review » Needs work

Thank you Steffen

Can you please address the issue mentioned in the merger request.

alexpott made their first commit to this issue’s fork.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Fix the PHPStan build by mostly fixing stuff and adding baseline.
Fixed cspell job.

As all lint jobs are now passing made build fail if any of them fail - so we don't regress.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Priority: Normal » Critical

Without this issue landing this module cannot have automated tests. Therefore raising this to critical. The DrupalCI tests are failing due to the way it installs dependencies. Gitlab CI does this in a different, better way, meaning that tests are working again.

daniel.bosen’s picture

daniel.bosen
he/him
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me now

  • RoSk0 committed 3e350e9b on 2.0.x authored by IT-Cru 
    Issue #3423376 by alexpott, IT-Cru: Add Drupal Gitlab templates
rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Reviewed & tested by the community » Fixed

Great community spirit and effort! Thanks heaps!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.