Steps to reproduce

1. Download the theme.
2. Create Menus.
3. Menus get distorted.

CommentFileSizeAuthor
#15 Screenshot from 2025-01-16 18-32-00.png30.92 KBsourojeetpaul
#15 Screenshot from 2025-01-16 18-30-23.png25.45 KBsourojeetpaul
#14 image (1).png25.41 KBsandip
#12 Screenshot from 2025-01-15 18-39-18.png51.19 KBsourojeetpaul
#12 Screenshot from 2025-01-15 18-29-41.png68.35 KBsourojeetpaul
#9 Screenshot from 2025-01-14 17-49-38.png11.26 KBsourojeetpaul
#9 Screenshot from 2025-01-14 17-49-07.png80.22 KBsourojeetpaul
#8 Issue-3423145.png10.41 KBsandip
#3 patch_warning.png16.76 KBalok_singh
#3 after.png104.31 KBalok_singh
#2 menu_css_fixed-3423145-2.patch2.28 KBdivyanshi
#2 after.png11.96 KBdivyanshi
before.png10.07 KBdivyanshi

Issue fork animal_shelter-3423145

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Divyanshi created an issue. See original summary.

divyanshi’s picture

divyanshi commented
Assigned: divyanshi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new after.png11.96 KB
new menu_css_fixed-3423145-2.patch2.28 KB
alok_singh’s picture

alok_singh commented
Status: Needs review » Needs work
StatusFileSize
new after.png104.31 KB
new patch_warning.png16.76 KB

Hi @divyanshi Please rework on menu that is still distorted, when added some submenu.
Also when i add extra menu item is not styled.
Added screenshot for reference.
when applying patch there is also message of warning: 1 line adds whitespace errors.
Thanks.

after
Patch warning.

niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s
niharika.s’s picture

niharika.s commented
Assigned: niharika.s » Unassigned
sandip’s picture

sandip commented
Assigned: Unassigned » sandip

Working on it.

sandip poddar opened merge request !20

sandip’s picture

sandip commented
Assigned: sandip » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Issue-3423145.png10.41 KB
sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2025-01-14 17-49-07.png80.22 KB
new Screenshot from 2025-01-14 17-49-38.png11.26 KB

Hi @sandip poddar,
Thanks for picking it up! The MR got applied cleanly, but I don't get to see any difference even after applying the patch. The submenu is not getting expanded on hover. Can you kindly have a look at it again?
Attaching before and after screenshots for ref.

sandip’s picture

sandip commented
Assigned: Unassigned » sandip

I am looking into it.

sandip’s picture

sandip commented
Assigned: sandip » Unassigned
Status: Needs work » Needs review

Hi @sourojeetpaul,
I was previously working on this issue in Drupal 9, and I have now reproduced it in Drupal 10. Could you please review the MR From my side, the hover effect appears to be working as expected.

Additionally, I resolved the merge conflict and made updates to menu--main.html.twig to address the issue.

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2025-01-15 18-29-41.png68.35 KB
new Screenshot from 2025-01-15 18-39-18.png51.19 KB

Hi @sandip poddar,
The merge conflicts have been resolved as I can see and now I'm able to see your results coming into play. But I've some concerns regarding the styling and the behaviour of the expanded menus. The sub menu panel is completely blending with the white background, so I'd like to see a distinction b/w them, we can implement that by adding a box shadow. Also we should also consider for multi-level expanded menu, which I think haven't been resolved! I'm moving it back to NW once again, please have a look.
Attaching screenshots for better ref.

sandip’s picture

sandip commented
Assigned: Unassigned » sandip

I am working on the feedbacks.

sandip’s picture

sandip commented
Assigned: sandip » Unassigned
Status: Needs work » Needs review
StatusFileSize
new image (1).png25.41 KB

hi @sourojeetpaul,
Please review the changes :)

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2025-01-16 18-30-23.png25.45 KB
new Screenshot from 2025-01-16 18-32-00.png30.92 KB

Hi @sandip poddar,
The changes look good to me now, the suggested changes have been incorporated well. Thanks for the prompt action. I'd be happy to ship it in!
Adding screenshots over here for better visibility and tracking.

sourojeetpaul’s picture

sourojeetpaul commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.