Problem/Motivation
In #3421703: Move batch functionality into check plugin we've made it possible for a plugin to run in batches, removing the need to create a separate batch process for plugins that need long scan processes. However, the views access still uses the old mechanism. This should be updated.
Proposed resolution
Replace the logic in include_batches/views_access.batch.inc with code in the run() method of Plugin/SecurityCheck/ViewsAccess.php. Refer to Plugin/SecurityCheck/NamePasswords.php for an example. You may refer to the merge request for #3421703: Move batch functionality into check plugin to see how the old implementation was converted to the plugin version.
Remaining tasks
- Do the port
- Create merge request
- Review
- Merge
User interface changes
The views access scan will take place in the main batch progress instead of in a second one after the main one has finished.
API changes
None.
Data model changes
None.
Issue fork security_review-3422431
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
smustgrave commentedComment #5
eelkeblokLooks good and works as advertised.
Comment #6
eelkeblokComment #8
smustgrave commentedThanks!
Comment #9
smustgrave commented