Problem/Motivation

In #3421703: Move batch functionality into check plugin we've made it possible for a plugin to run in batches, removing the need to create a separate batch process for plugins that need long scan processes. However, the views access still uses the old mechanism. This should be updated.

Proposed resolution

Replace the logic in include_batches/views_access.batch.inc with code in the run() method of Plugin/SecurityCheck/ViewsAccess.php. Refer to Plugin/SecurityCheck/NamePasswords.php for an example. You may refer to the merge request for #3421703: Move batch functionality into check plugin to see how the old implementation was converted to the plugin version.

Remaining tasks

  • Do the port
  • Create merge request
  • Review
  • Merge

User interface changes

The views access scan will take place in the main batch progress instead of in a second one after the main one has finished.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

eelkeblok created an issue. See original summary.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

Status: Active » Needs review
Parent issue: » #3409236: META 3.0.0
eelkeblok’s picture

Status: Needs review » Reviewed & tested by the community

Looks good and works as advertised.

eelkeblok’s picture

  • smustgrave committed cef5c379 on 3.0.x
    Issue #3422431: Port views access batch to new plugin mechanism
    
smustgrave’s picture

Thanks!

smustgrave’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.