Standard profile installation
Latest 1.x navigation module
Enable Stark theme here /admin/appearance and set it as Default theme.
Visit homepage

test

Issue fork navigation-3421563

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kostyashupenko created an issue. See original summary.

kostyashupenko’s picture

Gonna fix it quickly

kostyashupenko’s picture

Status: Active » Needs review
ckrina’s picture

@kostyashupenko good catch! I'm wondering if there's a way to do this all at once and maybe this fix will solve this issue so we don't have to add this extra attribute to every component? https://www.drupal.org/project/navigation/issues/3402592#mr174-note266578

kanchan bhogade’s picture

StatusFileSize
new93.73 KB

Hi @kostyashupenko
Checked on Drupal 11.x without a patch it looks good to me
if I missing something please let me know so it can be helpful to reproduce the issue

Attaching screenshot

kostyashupenko’s picture

Re #5
i was thinking what i can do - i decided to switch logic a bit in CSS. Now `font-family: inherit` is still placed in two difference places, but that's why:
1. I want to keep such "base" styles only in the scope of navigation module
2. Top bar is placed in the difference place in DOM tree than admin toolbar.
Looks ok now i think

Re #6
This issue can be reproduced only with some custom themes, not with core themes like Claro or like Olivero (the theme on your screenshot). These two themes have `button { font-family: inherit }` already.

kanchan bhogade’s picture

Assigned: kostyashupenko » Unassigned
StatusFileSize
new29.44 KB
new31.92 KB
new29.94 KB
new33.39 KB

Thank you @kostyashupenko able to reproduce the issue with your inputs.

I have tested MR !176 on Drupal version 10.2.2 with a custom theme
The patch was applied successfully...

Result:
The Font issue for custom themes is resolved with MR !176
RTBC++

Attaching screenshots for reference

Keeping in "needs review" for code verification

ckrina’s picture

What I meant in #5 is if it would it work to do something like this:

:where([data-admin-ui-initial-styles]) * {
    font-family: inherit;
}

This way this would be defined in the admin-initial-styles.css for all components without the need to specify it on each component file.

If that approach works it'd mean to postpone this issue until #3402592: Reset theme css. is in and this gets integrated in that file.

ckrina’s picture

Status: Needs review » Needs work

@kostyashupenko is this still happening after merging #3402592: Reset theme css. ? And can this maybe be added in the new admin-reset-s‎tyles.pcss.css‎ file?

ckrina’s picture

Assigned: Unassigned » kostyashupenko
Status: Needs work » Needs review

@kostyashupenko is this still happening?

kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
ckrina’s picture

@kostyashupenko would it be possible to have testing instructions to test it on my local? Like which theme you are using, or which changes you are recreating to test it. Thanks!

kostyashupenko’s picture

@ckrina just enable core theme "Stark" and set it as default theme. Then visit homepage )

kostyashupenko’s picture

Issue summary: View changes

ckrina credited finnsky.

ckrina’s picture

Status: Needs review » Fixed

Tested locally and it works perfect, thanks! I also like the admin-reset-styles library on its own so we can move it into its own thing in the future.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.