Problem/Motivation

In some cases it seems that VLSuiteModalConfigOverride::__construct is getting an empty request from the request stack.

Steps to reproduce

At least in my case is happening in every request.

Proposed resolution

Call requestStack->getCurrentRequest() just before using it.
And if needed use a method to set the request in a class property for multiple usages.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork vlsuite-3420000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SadySierralta created an issue. See original summary.

SadySierralta opened merge request !38

crzdev’s picture

crzdev commented
Related issues: +#3410384: Layout Builder modal dialog is broken with Drupal 10.1+
sadysierralta’s picture

sadysierralta commented
Status: Active » Needs review

  • CRZDEV committed 4d33423d on 1.1.x authored by SadySierralta 
    Issue #3420000 by SadySierralta, CRZDEV: TypeError: Cannot assign null...
crzdev’s picture

crzdev commented
Status: Needs review » Reviewed & tested by the community

LGTM!

crzdev’s picture

crzdev commented
Version: 1.1.x-dev » 1.1.2
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.