Problem/Motivation

Our gitlabci template makes use of the CI_MERGE_REQUEST_PROJECT_URL environment variable for fetching.
This assumes the repository is publicly available and doesn't work for private repositories.

The security team has a private fork of core on our gitlab instance for testing security issues.

Tests currently fail on the use of this variable because we can't fetch the repository over https

Steps to reproduce

Proposed resolution

Use 'origin' instead of the repository URL

Remaining tasks

- The git diff in the test-only job might need to change. Do first in D10+ and then port.

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/A

Issue fork drupal-3419409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !6471

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

Fixed based on what was done for D10+.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

I've confirmed this passes in private testing.

  • poker10 committed 4e00a40a on 7.x 
    Issue #3419409 by fjgarlin: [D7] Make CI template compatible with...
poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed

Thank you both for working on this and also for confirmation that it fixed the private testing for D7. I have compared the MR with the D10 commit code and the changes are the same. Committed/pushed this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.