The module should contain composer.json file.

Issue fork manage_display-3419164

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AstonVictor created an issue. See original summary.

AstonVictor opened merge request !15

astonvictor’s picture

astonvictor commented
Status: Active » Needs review

Created a new MR with a composer.json file.

adamps’s picture

adamps commented
Status: Needs review » Active

According to this page https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file it is optional. What do you see as the advantages?

Why "minimum-stability": "dev"?

raveen_thakur51’s picture

raveen_thakur51 commented

@. For prod env, I believe it is "stable" to ensure only stable releases are installed. However, for dev, including development versions can be beneficial for testing new features or bug fixes.

** Adding a composer.json file may bring several advantages like Dependency Management, Version Control & ease of updating.

astonvictor’s picture

astonvictor commented
Status: Active » Needs review

thanks @Raveen Thakur

adamps’s picture

adamps commented

On the page I linked to in #4 is says this:

When prompted for Minimum Stability []:, hit enter to use the the default of "stable" stability. This will have no effect on websites where your code is installed, but may affect which versions of dependencies are used when running your project's tests. Stable dependencies during testing is preferred to unstable ones.

I searched all the modules installed on one of my sites. The majority leave it out altogether so perhaps that's best??

astonvictor’s picture

astonvictor commented
Status: Needs review » Closed (won't fix)

ok, in that case I’ll close the MR

AstonVictor closed merge request !15

adamps’s picture

adamps commented

I have very little time now for Drupal, so I will try to leave you as much freedom as possible. You can commit it is you like.

AstonVictor reopened merge request !15

astonvictor’s picture

astonvictor commented
Status: Closed (won't fix) » Fixed

thanks.

merged the MR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.