Problem/Motivation

In view save and cancel buttons overlap with the above component and do not have any space between both buttons. See attached screenshots for reference

Steps to reproduce

  1. Install the theme and set it as an admin theme
  2. Go to any view
  3. See save and cancel button spacing and overlapping issue with the above component

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 After Patch.png68.61 KBsandeep_k
#8 Before Patch.png61.79 KBsandeep_k
#5 issue.png13.04 KBtanuja bohra
#4 after-patch.png20.31 KBsourabhjain
Screenshot at Feb 02 12-48-52.png93.01 KBshweta__sharma

Issue fork root-3418818

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

I have figured out the issue. Let me try to fix it.

sourabhjain opened merge request !7

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
Status: Active » Needs review
StatusFileSize
new after-patch.png20.31 KB

I have resolved the issue. Please review MR
Attaching screenshot after update.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Needs work
StatusFileSize
new issue.png13.04 KB

@sourabhjain verified MR7 and the overlapping concern is resolved, but the other issue mentioned in the problem description - "do not have any space between both buttons" is still present.

shweta__sharma opened merge request !10

shweta__sharma’s picture

shweta__sharma commented
Status: Needs work » Needs review
sandeep_k’s picture

sandeep_k commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png61.79 KB
new After Patch.png68.61 KB

Hi, I've tested MR- MR !10 mergeable on Drupal version- 9.5.12-dev. The patch was applied successfully and looks good to me.

Testing Steps:

  • Download/install the Theme "Root - Administration Drupal theme"
  • Go to Structure> Create new or edit an existing view, and scroll down to save/cancel buttons. Attached before result.
  • Download this patch and Apply.
  • Go back to the Structure/Views- and re-verify this.

Testing Results:
After applying the patch, the Spacing issue is fixed now, adding after result. RTBC++

sourabhjain’s picture

sourabhjain
Primary language English
commented

@shweta__sharma we have already created a MR 7 so I don't see any reason to create new PR. Could you please close one of them. It will create a confusion.

ahmad-alyasaki closed merge request !7

ahmad-alyasaki made their first commit to this issue’s fork.

ahmad-alyasaki’s picture

ahmad-alyasaki commented

Thanks all for your contributions

ahmad-alyasaki’s picture

ahmad-alyasaki commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.