Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Decided to bundle these ones together as they aren't very different from each other.

Steps to reproduce

Proposed resolution

Three are converted to Prophecy, one remains as a PHPUnit mock because that was the easiest thing to do.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3418457

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6415

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems to have a failure.

Akhil Babu made their first commit to this issue’s fork.

akhil babu’s picture

akhil babu
he/him
commented

I have removed the commented code in core/tests/Drupal/Tests/Core/Menu/LocalTaskManagerTest.php. Also fixed coding standard errors.

akhil babu’s picture

akhil babu
he/him
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Reverted the out of scope changes, fixed the other issues.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks @longwave, reviewing MR I see green and don't see any coverage is lost.

  • catch committed 02f3e0c3 on 11.x 
    Issue #3418457 by longwave, Akhil Babu: Remove withConsecutive() in menu...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This is nearly as big a diff as all the other MRs combined, who knew menu tests were relying on it so much, but mostly shifting from expects/withConsecutive to ::shouldBeCalled() feels like a small net improvement much like the other issues. Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.