Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

We don't need to assert the order that modules are loaded in here, so we can use Prophecy to do this more easily.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3418453

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: #3417528: Remove withConsecutive() in MigrateSqlIdMapEnsureTablesTest » #3406006: [META] Convert use of InvocationMocker::withConsecutive()
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !6414

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work

Merge conflict + PHPStan being too good at its job.
Maybe a @phpstan-ignore-next-line and a comment why is in order?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Rebased, if we change the docblock then PHPStan doesn't think it is a real ModuleHandlerInterface any more.

spokje’s picture

spokje
Primary language Dutch
commented

if we change the docblock then PHPStan doesn't think it is a real ModuleHandlerInterface any more.

Yep, that works.

Do we need to add a comment why we don't do the "normal" union type here?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Honestly not sure it's worth it, the comment and variable name tell you what it is.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Fine by me

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

  • catch committed e036e737 on 11.x 
    Issue #3418453 by longwave, Spokje: Remove withConsecutive() in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.