Problem/Motivation

Add name attributres for the form in SPA (attach/detach interface).

Issue fork cloud-3418203

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !2225

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ryo-yamashita

Thank you for the fix. The patch reveals the essential problem. I posted my comments. Please make sure of it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add name attributres for the form in SPA (attach/detach interface) » Add the name attributes for the form in SPA (attach/detach OpenStack interface)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

  • yas committed 49edbb5e on 6.x authored by Ryo Yamashita 
    Issue #3418203 by Ryo Yamashita, yas: Add the name attributes for the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Can you create the MR for the 5.x branch? Thanks

error: patch failed: modules/cloud_dashboard/js/index.js:300
error: modules/cloud_dashboard/js/index.js: patch does not apply
 .../constant/templates/form/openstack/instance.ts  |    2 ++
 modules/cloud_dashboard/js/index.js                |    2 +-
 .../OpenStack-ATDD-03-05-OperateInstances.feature  |    4 +++-
 3 files changed, 6 insertions(+), 2 deletions(-)

error: patch failed: modules/cloud_dashboard/js/index.js:300
error: modules/cloud_dashboard/js/index.js: patch does not apply
On branch 5.x
Your branch is up to date with 'origin/5.x'.

Ryo Yamashita opened merge request !2226

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed this patch for origin/5.x. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and close this issue as Fixed.

  • yas committed 61aa5cec on 5.x authored by Ryo Yamashita 
    Issue #3418203 by Ryo Yamashita, yas: Add the name attributes for the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.