Closed (fixed)
Project:
Drupal core
Version:
11.1.x-dev
Component:
typed data system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Jan 2024 at 18:28 UTC
Updated:
6 Dec 2024 at 14:09 UTC
Jump to comment: Most recent
Comments
Comment #4
rohit sankhlaAdded last method in Drupal/Core/TypedData/Plugin/DataType/ItemList.php, Please review.
Comment #5
smustgrave commentedWill need simple test coverage
Change record
And should have a return typehint
Comment #7
shalini_jha commentedI have added return value for last method same as first method.
Comment #8
shalini_jha commentedI have added the Test coverage and Change record for this. The change record is currently in draft. Moving this for NR, kindly review.
Comment #9
smustgrave commentedComment #10
shalini_jha commentedComment #11
shalini_jha commentedMoving this to NR.
Comment #12
smustgrave commentedFixed return syntax. Rest appears good and feedback addressed.
Comment #13
alexpottI searched contrib and there doesn't appear to be any clashing functions and this helps to make the interface more fluent and natural so +1
Committed and pushed b7ce2ab918e to 11.x and c0327e8d90c to 11.1.x. Thanks!