Problem/Motivation

Steps to reproduce

there should be visible difference between the menu and main content region
eitherit should after hover or any how

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Screenshot from 2024-11-06 18-00-36.png93.92 KBsourojeetpaul
#5 Screenshot from 2024-11-06 18-00-28.png80.55 KBsourojeetpaul
Screenshot from 2024-01-29 11-53-24.png202.3 KBsanskar mishra

Issue fork animal_shelter-3417690

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sanskar mishra created an issue. See original summary.

shweta__sharma made their first commit to this issue’s fork.

shweta__sharma opened merge request !8

shweta__sharma’s picture

shweta__sharma commented
Status: Active » Needs review

Added box shadow to the header. Kindly review it.
Thanks

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-11-06 18-00-28.png80.55 KB
new Screenshot from 2024-11-06 18-00-36.png93.92 KB

Hello,
Thanks for reporting the issue and working on it. There was legit no clear distinction between menu and main content. After applying the patch that issue is resolved, the MR also looks good.
On the front page it looks absolutely fine to me, but on the individual node page, I feel a scarcity of breathing space between menu and the breadcrumb. Attaching both the screenshots for quick refs. Please have a look and will be highly appreciated if you come up with any solution to fix that. Hence I'm moving that back to NW :(

Thanks and Regards!

jaydeep_patel made their first commit to this issue’s fork.

jaydeep_patel’s picture

jaydeep_patel commented

Hello @sourojeetpaul,

I've updated the MR!8 and added padding on top and bottom of the Breadcrumb as per your comment.

Thank you

jaydeep_patel’s picture

jaydeep_patel commented
Status: Needs work » Needs review

Hello @sourojeetpaul,

I've updated the MR!8 and added padding on top and bottom of the Breadcrumb as per your comment.

Thank you

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work

Back to NW for merge conflicts.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »

Will work on resolving Merge conflicts

Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
Status: Needs work » Needs review

sourojeetpaul
I resolved the merge conflicts as asked,
Can you please give it a look

jaydeep_patel’s picture

jaydeep_patel commented
Status: Needs review » Reviewed & tested by the community

MR !8 applied successfully without any conflict and looks good now.
Thanks @akulsaxena for resolve conflicts.

Moving this issue to RTBC.

sourojeetpaul’s picture

sourojeetpaul commented
Status: Reviewed & tested by the community » Fixed

The MR is clean now, and the suggested changes have been incorporated, hence I'm shipping this in. Thanks everyone for your contribution :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.