Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

We don't need to assert the order that entities are (de)normalized in, as long as they all are (de)normalized, so we can use Prophecy to do this more easily.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3417551

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6345

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Code changes make sense.

Added to IS that in this case, the order in which entities are (de)normalized doesn't matter, as long as they are all (de)normalized, which is what is being tested in the MR.

RTBC for me.

  • catch committed 5ee806ab on 10.2.x 
    Issue #3417551 by longwave, Spokje: Remove withConsecutive() in...

  • catch committed 8474508c on 11.x 
    Issue #3417551 by longwave, Spokje: Remove withConsecutive() in...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

longwave closed merge request !6345

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.