Problem/Motivation

hook_help() missing from link_field_entity_filter.module file.
In Drupal, the hook_help function is used to provide help documentation for your custom module. This documentation is displayed on the Help page of your Drupal site, making it accessible to administrators and users.

CommentFileSizeAuthor
#9 hook-help-page.png189.7 KBcleavinjosh
#9 after-patch.png62.48 KBcleavinjosh
#9 before-patch.png63.87 KBcleavinjosh
#6 rambo-shooting.gif3 MBwhitedevil

Issue fork link_field_filter-3415804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akhil_01 created an issue. See original summary.

akhil_01 opened merge request !1

akhil_01’s picture

akhil_01 commented

Hi @Ankit_Kumar @whitedevil

I have created MR For the Adding Hook help in this module

please review it once

Thank you

apatel0325’s picture

apatel0325 commented
Assigned: Unassigned » apatel0325
apatel0325’s picture

apatel0325 commented
Assigned: apatel0325 » Unassigned
Status: Active » Needs review
whitedevil’s picture

whitedevil commented
StatusFileSize
new rambo-shooting.gif3 MB
whitedevil’s picture

whitedevil commented
StatusFileSize
new rambo-shooting (1).gif338.03 KB
whitedevil’s picture

whitedevil commented
cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before-patch.png63.87 KB
new after-patch.png62.48 KB
new hook-help-page.png189.7 KB

Hi @akhil_01, apatel0325,

I applied MR!1, it was applied smoothly and added the hook help.

Please see my attached files.

As per the phpcs mentioned on comment #4, I still encounter some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

➜  link_field_filter git:(main) ✗ curl https://git.drupalcode.org/project/link_field_filter/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1633    0  1633    0     0    782      0 --:--:--  0:00:02 --:--:--   782
patching file link_field_entity_filter.module
➜  link_field_filter git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml link_field_filter

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/link_field_filter/link_field_entity_filter.info.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
 6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
------------------------------------------------------------------------------------------------------------------------

Time: 140ms; Memory: 10MB

I will now move the status to Reviewed & tested by the community since the issue is about the hook help.

Thank you.

whitedevil’s picture

whitedevil commented
ankit_kumar’s picture

ankit_kumar
He/Him
commented

Thanks for your contribution. It will be fixed in the next release

ankit_kumar’s picture

ankit_kumar
He/Him
commented
Status: Reviewed & tested by the community » Fixed
ankit_kumar’s picture

ankit_kumar
He/Him
commented
Status: Fixed » Closed (fixed)