1. git checkout 1.x
2. git pull --rebase
3. If you recently already had `Navigation` module enabled on your local instance, then run drush pmu -y navigation && drush en -y navigation // easiest way, since a lot of was merged recently in 1.x
4. Create any node
5. Visit node page
6. Click on "More actions" in top bar and try to click in outside area.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | video.gif | 316.49 KB | sandeep sanwale |
| #10 | 3415785-10.patch | 1.75 KB | sandeep sanwale |
| #8 | dropdown-navigation.gif | 322.14 KB | ahsannazir |
| Снимок экрана 2024-01-19 в 15.04.08.png | 88.8 KB | kostyashupenko |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
kostyashupenkoComment #3
kostyashupenkoComment #4
kostyashupenkoComment #5
kostyashupenkoComment #6
ahsannazir commentedComment #8
ahsannazir commentedRaised MR for hiding dropdown when clicking outside dropdown
Comment #9
finnsky commentedLooks good to me! Thank you!
Comment #10
sandeep sanwale commentedDone some changes in dropdown JS.
Comment #11
finnsky commented@Sandeep Sanwale thank you for your patch.
In this ticket it is enough to get just `close on outside click`
In your patch i see things which we need to discuss first. like:
`e.stopPropagation();`
Please feel free to open new issue with that javascript optimisations.
Comment #12
ckrinaMerged, thanks!
And for the JS improvements, feel free to open a new issue as @finnsky says so those specific suggestions can be discussed without blocking this :)