Problem/Motivation

Follow up to #3380345: Create an InputStreamFileWriter for writing the input stream to a file. The CR link in the deprecation messages in FileUploadResource and TemporaryJsonapiFileFieldUploader was left as a placeholder 'https://www.drupal.org/node/123'.

Steps to reproduce

Proposed resolution

Update it to the correct URL https://www.drupal.org/node/3380607

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3415422

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

kim.pepper opened merge request !6218

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Fix incorrect change record url in FileUploadResource constructor » Fix incorrect change record link in FileUploadResource and TemporaryJsonapiFileFieldUploader constructors
Issue summary: View changes
Status: Active » Needs review
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Pretty sure the nightwatch test fail is not related:

  ️TEST FAILURE (1m 46s): 
   - 1 error during execution; 
   - 0 assertions failed; 1920 passed
   ✖ 3) Tests/ckEditor5CodeSyntaxTest
  - OTHER ERRORS:
  1)  Error
   Command failed: php ./scripts/test-site.php user-login 1 --site-path sites/simpletest/83280078
In Database.php line 455:
                                                             
  The specified database connection is not defined: default  
                                                             
user-login [--site-path SITE-PATH] [--] <uid>

Update: random fail

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Simple enough update.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Good spot, thanks for catching.

Committed fc1a8d5 and pushed to 11.x. Thanks!

  • longwave committed fc1a8d51 on 11.x 
    Issue #3415422 by kim.pepper: Fix incorrect change record link in...

longwave credited arunkumark.

longwave credited quietone.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Transferring credit from #3414700: Fix change record URL in deprecation message for #3380345 which is an exact duplicate.

longwave closed merge request !6218

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.