Problem/Motivation

https://www.drupal.org/project/navigation/issues/3402046#comment-15372504

We added control bar but it displayed optional in backend.
But on mobile inside this control bar we have `Expand button`.
In cases when control bar not displayed we cannot open toolbar on mobile.

Temp button added there. We need to remove it after fix in this ticket. 

{# Temporary bar for mobile. https://www.drupal.org/project/navigation/issues/3402046#comment-15402086 #}
<div class="temp-bar" style="padding: 20px">
  <style>
    @media (min-width: 64rem) {
      .temp-bar {
        padding: 20px;
        display: none;
      }
    }
  </style>
  <button aria-controls="admin-toolbar">{{ 'Expand sidebar'|t }}</button>
</div>

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork navigation-3415330

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Priority: Normal » Critical
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Issue tags: +frontend
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Title: Always display top(control) bar. » Always display top (control) bar

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko opened merge request !166

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review

I did the easiest available thing. Since expand side nav button is a part of top_bar template - i decided to keep the same logic.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Needs work

Small suggestions. See MR for threads. Nice work!

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

Removed that `not-needed` class
In favor of combination of:

:has https://caniuse.com/css-has
AND
:only-child https://caniuse.com/mdn-css_selectors_only-child

Addressed feedbacks.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Needs work

Looks like this needs to be rebased against the latest 1.x since #3415311: Decouple from Toolbar module was merged. See also one additional comment on updating the permission that we use here.

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

rebased

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks great! Thanks for the quick changes.

RTBC for me.

ckrina closed merge request !166

ckrina reopened merge request !166

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Merged. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.