Problem/Motivation

Drupal\FunctionalTests\Core\Container\ServiceDeprecationTest Makes no HTTP requests but is a functional test.

Proposed resolution

Convert Drupal\FunctionalTests\Core\Container\ServiceDeprecationTest into a Kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3415167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Hardik_Patel_12 created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented

Not sure why we're opening up an issue when both the META and the class PHPDoc explicitly state:

Note: this test must be a BrowserTestBase so the container is properly compiled.

hardik_patel_12’s picture

hardik_patel_12 commented

Conveying uncertainty, there appears to be a plausible opportunity to convert it into a kernel test case. Furthermore, I have removed the links integrated into the parent issue. Any insights or feedback on this approach would be highly appreciated.

spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: #3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests »
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

As the comment says this must be a functional test in order to ensure that the deprecations are correctly triggered at runtime, kernel tests do not use a compiled container and so they are not a valid test in this case.

As one of the contributors to the issue where this was introduced, to me this is won't fix.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Closed (won't fix)

Thanks @longwave for confirming.

Let's pull the trigger.