Hi, I have a multi-domain setup using the Domain module.

I have different themes on different domains, one of which has Gin with the toolbar and this module installed.
Currently this module changes the admin toolbar for all the thems, I would like it to only affect Gin.

In this issue I suggested to introduce alter hook to alter the _gin_toolbar_gin_is_active().

All works well with the MR I added, but it requires extra check if Gin toolbar is active in the gin_toolbar_custom_menu_toolbar_alter function provided by this module.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gilmord created an issue. See original summary.

gilmord’s picture

I did not dig why, but this patch (https://git.drupalcode.org/project/gin_toolbar_custom_menu/-/merge_reque...) + patch from related issue (https://git.drupalcode.org/project/gin_toolbar/-/merge_requests/38.patch) did the trick for me - I have regular adminimal toolbar on one domain and I have gin toolbar + custom menu for it on gin theme domain.

jmauricio’s picture

Assigned: Unassigned » jmauricio
Status: Active » Needs work
jmauricio’s picture

Assigned: jmauricio » Unassigned
Status: Needs work » Needs review

Changes merged into 1.0.x.

Thanks, this will be in the next release.

gilmord’s picture

@jmauricio thanks!

By the way I noticed interesting thing - this module successfully replace toolbar not only for Gin theme but for any theme.

In my case it worked for adminimal and for my custom theme.

Maybe we should consider replacing it with a global module, not limited to Gin theme

jmauricio’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.